fix: AppBio QuantStudio Design & Analysis - Check for valid rq values before setting r_sample and r_target#1138
Merged
nathan-stender merged 6 commits intomainfrom Mar 19, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves robustness of the AppBio QuantStudio Design & Analysis Relative Standard Curve parser by avoiding reference-sample/target inference when the RQ sheet has no usable Rq values, preventing conversion failures in those scenarios.
Changes:
- Added
_has_valid_rq_values()to detect whether the “RQ Replicate Group Result” sheet contains any non-nullRqvalues before attempting reference inference. - Updated
RelativeStandardCurveCreator.create()to setreference_sample/reference_targettoNonewhen no validRqvalues exist. - Relaxed the type of
r_sampleiniter_relative_standard_curve_calc_docs()to allowNone.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/allotropy/parsers/appbio_quantstudio_designandanalysis/structure/relative_standard_curve/creator.py |
Adds an RQ validity check and conditionally skips reference inference to avoid runtime errors. |
src/allotropy/parsers/appbio_quantstudio_designandanalysis/appbio_quantstudio_designandanalysis_calculated_documents.py |
Updates iter_relative_standard_curve_calc_docs signature to accept `r_sample: str |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...py/parsers/appbio_quantstudio_designandanalysis/structure/relative_standard_curve/creator.py
Show resolved
Hide resolved
...py/parsers/appbio_quantstudio_designandanalysis/structure/relative_standard_curve/creator.py
Show resolved
Hide resolved
...o_quantstudio_designandanalysis/appbio_quantstudio_designandanalysis_calculated_documents.py
Show resolved
Hide resolved
james-leinas
approved these changes
Mar 13, 2026
slopez-b
requested review from
nathan-stender
and removed request for
nathan-stender
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.